Added ability to run feature modules independent from main app module #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request Arello-Mobile#189 from AlexeyKorshun/develop
PR Arello-Mobile#212 (Android x)
…ized-view Fix types of parameters in methods from generic superinterfaces
|
Usage example for modules, which declare Application class: class MyApp: Application() {
override fun onCreate() {
super.onCreate()
MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE)
}
}Usage example for library modules, which don't have Application class: class MyModuleBaseActivity: MvpAppCompatActivity() {
override fun onCreate() {
super.onCreate()
MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE)
}
} |
…n module. This allows Instant App support (Arello-Mobile#209), running unit-tests for feature modules (Arello-Mobile#223) and other issues Arello-Mobile#224. Here, Moxy always references to MoxyReflector by com.arellomobile.mvp package and generates MoxyReflectorDelegate for each module. In order to use Moxy, there is no need to follow instructions described on this page https://github.com/Arello-Mobile/Moxy/wiki/Multiple-modules Now it is only required to add 1 line of code to BaseActivity.onCreate of each module : MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Instant App support [https://github.com//issues/209)],
running unit-tests for feature modules [https://github.com//issues/223]
and other issues [https://github.com//issues/224].
Here, Moxy always references to MoxyReflector by com.arellomobile.mvp package and generates
MoxyReflectorDelegate for each module.
In order to use Moxy, there is no need to follow instructions described on this page https://github.com/Arello-Mobile/Moxy/wiki/Multiple-modules
Now it is only required to add 1 line of code to each module's BaseActivity.onCreate, or App.onCreate or any place where feature module gets initialized : MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE);